Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check trusted flag against BigDecimal.ZERO instead of casting to int #4153

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Jun 16, 2023

Identify the Bug or Feature request

Fixes #4151

Description of the Change

The integral value passed as the trusted parameter of js.createNS() is represented as a BigDecimal, not a value that can be cast to int. This PR changes the comparison to check against BigDecimal.ZERO as is done in other macro functions.

Possible Drawbacks

Should be none

Documentation Notes

N/A

Release Notes

  • Fixed an error when using the two-parameter form of js.createNS()

This change is Reviewable

@cwisniew cwisniew added this pull request to the merge queue Jun 17, 2023
@cwisniew cwisniew added the bug label Jun 17, 2023
Merged via the queue into RPTools:develop with commit 98c0547 Jun 17, 2023
@kwvanderlinde kwvanderlinde deleted the bugfix/4151-js.createNS-ClassCastException branch August 31, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Bug]: js.createNS() ClassCastException
2 participants