Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update themed CSS #4189

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented Jul 1, 2023

Identify the Bug or Feature request

Resolves #4187

Description of the Change

Adds the following to the themed CSS

  --mt-theme-panel-background: ...;
  --mt-theme-panel-foreground: ...;

  --mt-theme-progress-bar-arc: ...;
  --mt-theme-progress-bar-background-color: ...;
  --mt-theme-progress-font-family: ...;
  --mt-theme-progress-font-size: ...;

  --mt-theme-scroll-bar-background-color: ...;
  --mt-theme-scroll-bar-show-buttons: ...;
  --mt-theme-scroll-bar-thumb-highlight-color: ...;
  --mt-theme-scroll-bar-thumb-arc: ...;
  --mt-theme-scroll-bar-thumb-border-color: ...;
  --mt-theme-scroll-bar-thumb-shadow-color: ...;
  --mt-theme-scroll-bar-thumb-dark-shadow-color: ...;
  --mt-theme-scroll-bar-thumb-color: ...;
  --mt-theme-scroll-bar-thumb-insets-left: ...;
  --mt-theme-scroll-bar-thumb-insets-top: ...;
  --mt-theme-scroll-bar-thumb-insets-right: ...;
  --mt-theme-scroll-bar-thumb-insets-bottom: ...;

Also updated comments where missing in CSS extraction classes and changed constructor for the classes to accept function to format the colour rather than directly using static method of another class

Possible Drawbacks

Hopefully none

Documentation Notes

  --mt-theme-panel-background: ...;
  --mt-theme-panel-foreground: ...;

  --mt-theme-progress-bar-arc: ...;
  --mt-theme-progress-bar-background-color: ...;
  --mt-theme-progress-font-family: ...;
  --mt-theme-progress-font-size: ...;

  --mt-theme-scroll-bar-background-color: ...;
  --mt-theme-scroll-bar-show-buttons: ...;
  --mt-theme-scroll-bar-thumb-highlight-color: ...;
  --mt-theme-scroll-bar-thumb-arc: ...;
  --mt-theme-scroll-bar-thumb-border-color: ...;
  --mt-theme-scroll-bar-thumb-shadow-color: ...;
  --mt-theme-scroll-bar-thumb-dark-shadow-color: ...;
  --mt-theme-scroll-bar-thumb-color: ...;
  --mt-theme-scroll-bar-thumb-insets-left: ...;
  --mt-theme-scroll-bar-thumb-insets-top: ...;
  --mt-theme-scroll-bar-thumb-insets-right: ...;
  --mt-theme-scroll-bar-thumb-insets-bottom: ...;

Release Notes

  • Added further CSS entries to themed CSS

This change is Reviewable

@cwisniew cwisniew added the feature Adding functionality that adds value label Jul 1, 2023
@cwisniew cwisniew added this pull request to the merge queue Jul 3, 2023
Merged via the queue into RPTools:develop with commit b024db5 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Feature]: Additional colours for theme.css
2 participants