Fix errors caused by auras inside solid VBL #4204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of `null` we now return an empty area. This saves on the need to check for null as all callers either behave the same as for an empty area, or can check if the resulting area is empty if different action is needed.
cwisniew
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
#4203
Description of the Change
The cause of the error was that
FogUtil.calculateVisibility()returnsnullwhen visibility is completely blocked by VBL Rather than add additionalnullchecks to avoid the NPE, I've instead changed the result ofFogUtil.calculateVisibility()to never benull. All callers already had to treat this case the same as an empty area (since that is what it signals), and can still take optimized code paths by checking if the area is empty rather thannull.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is