Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix overlay flicker #4246

Merged

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Aug 14, 2023

Identify the Bug or Feature request

Attempts to fix #4241

Description of the Change

There was a workaround introducedd for #1976 where we set the overlay page background to something not-quite-transparent, otherwise the overlay contents might not be cleared. Unfortunately this appears to be the cause of the flickering that overlays are known to have. This PR removes the workaround and always sets the page to have a transparent background.

It is necessary to set the page background to invisible in updateContents() rather than just leaving it up to handlePage(). I found that if a stat sheet has content that takes a bit to load (e.g., Rev's "Anim" stat sheet), the overlay would render as pure white for a moment before transitioning to transaprent.

Possible Drawbacks

Documentation Notes

  • N/A

Release Notes

  • Fixed the flickering that sometimes happens when opening overlays and stat sheets.

This change is Reviewable

The workaround was needed as old overlay contents were not being erased when the page background was transparent. That
problem no longer seems to exist, so the workaround has been removed in favour of always setting a fully transparent
background. This also seems to fix the blue flicker that has plagued overlays.
@kwvanderlinde kwvanderlinde force-pushed the bugfix/4241-stat-sheet-blue-flicker branch from 10a2dcb to 9566e2d Compare August 14, 2023 16:25
@cwisniew cwisniew added this pull request to the merge queue Aug 14, 2023
Merged via the queue into RPTools:develop with commit 9b061ef Aug 14, 2023
@kwvanderlinde kwvanderlinde deleted the bugfix/4241-stat-sheet-blue-flicker branch August 14, 2023 23:20
@cwisniew cwisniew added the bug label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Bug]: New stat sheets have lots of blue flickering
2 participants