Stop the gradle daemon after the build task during verification #4261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need the gradle daemon anyways, so we can run gradle with the `--no-daemon` flag to stop the daemon after building. This will release the lock files and allow us to cache the gradle files for faster subsequent verification runs.
cwisniew
approved these changes
Aug 25, 2023
kwvanderlinde
deleted the
maintenance/4260-windows-build-verification-gradle-cache
branch
cwisniew
added
bug
code-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4260
Description of the Change
This just adds the
--no-daemonflag to gradle when executing thebuildtask. This way the lock files are released and windows will allowtarto do its job and the cache to be built.Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
N/A
This change is