JS API setProperty() fix. #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erverCommand(), but unsure whether this is wise...
thelsing
reviewed
Sep 26, 2023
src/main/java/net/rptools/maptool/client/script/javascript/api/JSAPIToken.java
Outdated
Show resolved
Hide resolved
thelsing
approved these changes
Sep 26, 2023
cwisniew
reviewed
Sep 26, 2023
src/main/java/net/rptools/maptool/client/script/javascript/api/JSAPIToken.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
resolves #4237
Description of the Change
Resolves the Server/Client inconsistency when server updates a token via one of the JS API
setName(),setNotes(), orsetProperty().Possible Drawbacks
Needs some more testing, and commentary by someone who understands the client<->server communication better.
Documentation Notes
Not much to really document - issue "how to reproduce" shows the problem fairly well - and now it shouldn't exist.
Release Notes
setName(),setNotes(), orsetProperty()didn't propagate to clients.This change is