Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zipfs to the jlink package. #4308

Merged
merged 6 commits into from
Sep 30, 2023
Merged

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented Sep 30, 2023

Identify the Bug or Feature request

Fixes #4307
There is also a small fix to LibraryManager to use the correct class in the logger, this was not causing the error but was the first fix I tried before stumbling on the real issue, its small enough fix that I left it in this

Description of the Change

Add js.zipfs to the included modules for jlink

Possible Drawbacks

Shoudld be none

Documentation Notes

Added js.zipfs to the included modules for jlink

Release Notes

  • Added js.zipfs to the included modules for jlink

This change is Reviewable

@cwisniew cwisniew added the bug label Sep 30, 2023
@cwisniew cwisniew added this pull request to the merge queue Sep 30, 2023
Merged via the queue into RPTools:develop with commit 9625df5 Sep 30, 2023
4 checks passed
@cwisniew cwisniew deleted the fix-class-not-found branch September 30, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Bug]: Loading built in addons fails when packaged as zipfs is not included in built JVM
2 participants