Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overeager parser preprocessor #4313

Merged
merged 1 commit into from
Oct 1, 2023
Merged

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented Oct 1, 2023

Identify the Bug or Feature request

Fixes #4312

Description of the Change

The change in PR #4304 was a bit overeager when trying to preprocess advanced rolls. This change ensures that the preprocessing will only occur when there is nothing else in the expression (other than white space).

Possible Drawbacks

There should be none, as the result can't sensibly be assigned to a variable or take part in arithmetic operations etc.

Documentation Notes

Fixes problems with if and strings that end with a letter and !

Release Notes

  • Fixes problems with if and strings that end with a letter and !

This change is Reviewable

@cwisniew cwisniew added the bug label Oct 1, 2023
@cwisniew cwisniew added this pull request to the merge queue Oct 1, 2023
Merged via the queue into RPTools:develop with commit a340565 Oct 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Bug]: if() parsing error
2 participants