Fix for error determining install directory on save/load #4331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-install-dir-save-issues
…niew/maptool into fix-install-dir-save-issues
cwisniew
changed the title
kwvanderlinde
approved these changes
Oct 19, 2023
cwisniew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4330
Description of the Change
Fixes MapTool so the save/load is only prevented to/from the actual install directory (and subdirectories).
I have also added a non-editable text field on the Application panel of the preferences dialog to allow users to easily see where MapTool thinks its installed if they need to report errors.
Possible Drawbacks
People could still save/load into the install directories of other versions they have installed, but there is no real way to really determine if a save directory is from another version/install, and we can only protect users from themselves so much.
Documentation Notes
Release Notes
This change is