Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the topology tooltips in the Edit Token dialog #4358

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Nov 1, 2023

Identify the Bug or Feature request

Fixes #4353

Description of the Change

The toggle buttons in the Topology panel of the Edit Token dialog now read as follows:

  • "Include Wall Vision Blocking Layer (Wall VBL) during move or copy"
  • "Include Hill Vision Blocking Layer (Hill VBL) during move or copy"
  • "Include Pit Vision Blocking Layer (Pit VBL) during move or copy"
  • "Include Movement Blocking Layer (MBL) during move or copy"

The parallel set of button on the main toolbar now also expand the initialisms for clarity:

  • "Draw Wall Vision Blocking Layer (Wall VBL)."
  • "Draw Hill Vision Blocking Layer (Hill VBL)."
  • "Draw Pit Vision Blocking Layer (Pit VBL)."
  • "Draw Movement Blocking Layer (MBL)."

Possible Drawbacks

More verbose tooltips on the toolbar could decrease readability for more familiar users.

Documentation Notes

Tooltips on topology toggles have changed for clarity and consistency.

Release Notes

  • Tooltips for topology toggles now use standardized terminology and clarify the what the intiialism stand for.

This change is Reviewable

The tooltips now consistently use the term "Vision Blocking Layer" with an associated type ("Wall", "Hill", or
"Pit"), and "MBL" is a shorthand for "Movement Blocking Layer".
Where they used to read "Draw Wall VBL", "Draw MBL", etc., they now read "Draw Wall Vision Blocking Layer (Wall VBL)",
"Draw Movmeent Blocking Layer (MBL)", etc. The intent is to give some clarity to these otherwise opaque initialisms.
@cwisniew cwisniew enabled auto-merge November 3, 2023 14:07
@cwisniew cwisniew added this pull request to the merge queue Nov 3, 2023
Merged via the queue into RPTools:develop with commit bcd4df4 Nov 3, 2023
4 checks passed
@cwisniew cwisniew added the bug label Nov 3, 2023
@kwvanderlinde kwvanderlinde deleted the bugfix/4353-fix-edit-token-topology-tooltips branch November 8, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[Bug]: Non-standard wording for topology types in Edit Token dialog
3 participants