Avoid use of convention properties #4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses warnings around the `java` and `application` plugins removing their convention properties in Gradle 9.0.
This avoids a warning about `:test` compatibility with Gradle 9.0.
This brings proper Java 20 support instead of the partial support present in 8.2.1.
kwvanderlinde
force-pushed
the
refactor/4398-gradle-9-compatibility
branch
from
befbb3b to
1d9b014
Compare
thelsing
approved these changes
Nov 15, 2023
cwisniew
added
the
code-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Address #4398
Description of the Change
This changes avoids warning around convention properties and implicit test dependencies, and also upgrades to Gradle 8.4.
Also included is a refactoring to keep the list of
javaargs in a common place so thejpackageandapplicationtask configurations don't have to be manually kept in sync.Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
N/A
This change is