Include FOW exposure in pathfinding bounds #4407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since FOW blocks movement for player views, it can "push" optimal paths anywhere based on the exposure boundary. So we have to account for it when calculating the bounds of cells to be considered for pathfinding. Also we now clear the FOW blocked moves cache instead of the VBL blocked moves when FOW changes.
Instead of getting the current zone renderer, we now get the renderer for the zone that the walker was created with. This should in practice be the same thing, but reduces the walker's dependence on global knowledge and avoids potential edge cases. Also uses that renderer's player view rather than directly checking if the player is effectively a GM. The check can also be done when building the FOW geometry rather than on every potential cell step.
cwisniew
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4406
Description of the Change
FOW can influence pathfinding, but its bounds were not affecting the pathfinding bounds. This caused the walker to exclude cells that were actually valid. This PR fixes that, and also includes debug logging and minor clean up to improve the maintainability a bit.
Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is