Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert inclusion of shadowJar plugin "Replace home-grown uberJar with shadowJar plugin" #4421

Closed
wants to merge 2 commits into from

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Nov 17, 2023

Identify the Bug or Feature request

Undoes work for #4354

Description of the Change

Reverts #4385

Also includes a tweak to #4401 so that duplicate sentry.properties files can be coped with (to reduce annoyance with checking out different commits).

Possible Drawbacks

Still won't be able to use Graal for now.

Documentation Notes

N/A

Release Notes

  • Reverted fix for JS UDFs running on the standalone JAR release.

This change is Reviewable

@kwvanderlinde
Copy link
Collaborator Author

I may have figured out how to make runtime and shadow play nice. Will leave this PR up for now as testing that might take a while and I don't want to hold other things up.

@kwvanderlinde kwvanderlinde deleted the revert/4385 branch November 26, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant