Fix VisiiblityInspector's use of cover VBL #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool doesn't like `null` topology, so instead make sure cover VBL is empty.
kwvanderlinde
force-pushed
the
bugfix/visibility-inspector
branch
from
2f96c36 to
62d5778
Compare
cwisniew
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Improves on #3732
Description of the Change
The tool doesn't like
nulltopology, but its cover VBL was being set tonull. Instead we make sure it set the cover VBL to empty.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
N/A
This change is