Updated FunctionUtil to handle lib:// assets via AssetResolver
#4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/net/rptools/maptool/client/functions/MapFunctions.java
Outdated
Show resolved
Hide resolved
src/main/java/net/rptools/maptool/client/functions/MapFunctions.java
Outdated
Show resolved
Hide resolved
Updated MapFunctions CreateMap to use this. Updated InputFunction to use this.
ColdAnkles
changed the title
lib:// assets via AssetResolverlib:// assets via AssetResolver
|
If we can find any similar uses of |
|
sooo... if I have an image: token, what happens? |
Was you'd get a null, but now it should work, though I suspect there's a better way to implement. Probably should discourage using Image token names directly in this way, since afaik token names aren't unique. |
cwisniew
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #4626
resolves #4620 in a smarter fashion
Description of the Change
Updates FunctionUtil.getAssetKeyFromString() to handle both
asset://andlib://asset URLsPropagates that usage to both createMap, and input functions.
Possible Drawbacks
None
Documentation Notes
FunctionUtil now depends on AssetResolver imports
InputFunction now depends on FunctionUtil
Release Notes
Fixed several inconsistent inabilities to use
lib://assetsThis change is