Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly centre map labels and fix colors for some old labels that had wrong coloring. #4716

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented Mar 10, 2024

Identify the Bug or Feature request

Fixes #4706

Description of the Change

Labels are not being centred correctly, so I have updated the rendering to fix their locations.

Possible Drawbacks

This means labels created with RC1 will be in the wrong place with the next release.
Since the sizes of labels are different there will not be a pixel perfect match of locations for the labels but they will be centred in same location and their bounds will be very close to before 1.15.

Documentation Notes

Fixes rendering locations of labels

Pre 1.15

CleanShot 2024-03-10 at 11 41 52@2x

Fixes

CleanShot 2024-03-10 at 13 25 47@2x

Release Notes

  • Fix centering of

This change is Reviewable

@cwisniew cwisniew enabled auto-merge March 15, 2024 00:49
@cwisniew cwisniew added this pull request to the merge queue Mar 15, 2024
Merged via the queue into RPTools:develop with commit 7327ee7 Mar 15, 2024
4 checks passed
@cwisniew cwisniew added the bug label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Opening older campaign, text labels move and have invisible text color
2 participants