Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crowdin.yml to extend translation file suffix with locale #4792

Merged
merged 1 commit into from
May 27, 2024

Conversation

bubblobill
Copy link
Collaborator

@bubblobill bubblobill commented May 24, 2024

Identify the Bug or Feature request

closes #4344

Description of the Change

Currently Crowdin returns one file for each language using a a two letter code; e.g. _jp, _es, _en
This falls down when there are multiple locale translations that use the same code.
Changing the crowdin.yml export mask from:
translation: /%original_path%/%file_name%_%two_letters_code%.%file_extension%
to:
translation: /%original_path%/%file_name%_%locale_with_underscore%.%file_extension%
should resolve the issue.

Possible Drawbacks

none foreseeable if it works as expected, otherwise, tragic mayhem.

Documentation Notes

Translation file import fix

Release Notes

Translation file import fix


This change is Reviewable

…with additional locale identifier (e.g. en, en_au, en_gb)
@kwvanderlinde
Copy link
Collaborator

Do we need to rename our existing i18n files with this change?

@bubblobill
Copy link
Collaborator Author

bubblobill commented May 26, 2024

No. Currently the translated files are written by Crowdin as you see them. At present the en_au and en_gb files are not written because there are three en translations and we only get the one. This should result in the additional translations coming home to daddy.
On Crowdin most language files have no locale.

@cwisniew cwisniew added the feature Adding functionality that adds value label May 27, 2024
@cwisniew cwisniew added this pull request to the merge queue May 27, 2024
Merged via the queue into RPTools:develop with commit 9fb9996 May 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: English localisation not present for non US English
3 participants