Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run the InfoTextSwingWorker on the EDT thread (merge 1.15 change back into develop) #4816

Closed
wants to merge 6 commits into from

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented May 30, 2024

It's meant to be run off-thread, so use .execute() instead of .run().### Requirements for Contributing a Bug Fix or Enhancement

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in timely manner will result in a request for you to update the pull request
    and possibly closure of the pull request if it is not provided after this request.
  • After you create the pull request, all status checks must pass before a maintainer will review your contribution.

Identify the Bug or Feature request

Description of the Change

Possible Drawbacks

Documentation Notes

Release Notes


This change is Reviewable

kwvanderlinde and others added 5 commits May 26, 2024 00:31
It's meant to be run off-thread, so use `.execute()` instead of `.run()`.
…tion

Do not run the InfoTextSwingWorker on the EDT thread
Swap gridHorizontalHex.svg and gridVerticalHex.svg as they were backwards
…-grid-icons

Swap hex grid icons in Rod's theme
@cwisniew cwisniew requested a review from kwvanderlinde May 30, 2024 09:44
@cwisniew cwisniew closed this May 31, 2024
@cwisniew
Copy link
Member Author

Wrong way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants