Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onFirstInit running every time when there is JS but no MTS #4906

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented Sep 13, 2024

Identify the Bug or Feature request

fixes #4905

Description of the Change

The onFirstInit event will run only as intended when there is a JavaScript but no MTScript script defined for the event instead of on every reload.

Possible Drawbacks

Should be none

Documentation Notes

The onFirstInit event will run only as intended when there is a JavaScript but no MTScript script defined for the event instead of on every reload.

Release Notes

  • The onFirstInit event will run only as intended when there is a JavaScript but no MTScript script defined for the event instead of on every reload.

This change is Reviewable

@cwisniew cwisniew added the bug label Sep 13, 2024
@cwisniew cwisniew changed the title Fix onFistInit running every time when there is JS but no MTS Fix onFirstInit running every time when there is JS but no MTS Sep 24, 2024
@kwvanderlinde kwvanderlinde added this pull request to the merge queue Nov 12, 2024
Merged via the queue into RPTools:develop with commit e8c7ba9 Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: onFirstInit doesn't get tracked unless an mts file is provided
2 participants