Reduce number of interfaces scanned for UPnP gateways (reapply #4904) #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialogs were unstylish and intrusive, constantly stealing focus for no reason. While the glass pane does not mention the specific interfaces being scanned, they will be located in the logs in case it ever matters. Cherry-pick of c58a065 from release-1.15 branch.
Cherry-pick of 4a3d5ad from release-1.15 branch.
Cherry-pick of 0ccc673 from release-1.15 branch.
cwisniew
approved these changes
Sep 19, 2024
kwvanderlinde
deleted the
bugfix/4902-upnp-interfaces--reapply-to-develop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports PR #4904 to
develop.The only notable difference is that the UPnP glass pane logic had to be moved into
MapToolServerdue to the refactorings that have taken place ondevelop.This change is