Restrict each drawable light to its lumens level #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvanderlinde
force-pushed
the
feature/4936-render-lights-per-lumens-level
branch
2 times, most recently
from
0c714d9 to
064937a
Compare
cwisniew
approved these changes
Sep 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Environmental lighting continues to allow overlap between lumens levels as these are meant to be more natural and less mechanical regarding their rendering.
kwvanderlinde
force-pushed
the
feature/4936-render-lights-per-lumens-level
branch
from
e75018c to
740aec3
Compare
|
@cwisniew Looks like the verification got confused with the recent mac changes, and also affected the merge queue. Looks like we'll need manual intervention to merge this one (or I can close this PR and open an identical one). |
I can push it through |
kwvanderlinde
deleted the
feature/4936-render-lights-per-lumens-level
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Addresses #4936
Description of the Change
When using the "overtop" lighting style, weak lights will no longer overlap with strong lights. This lighting style is more closely related to mechanics, and so it gets confusing when different lumens levels have overlapping colours.
When using the "environmental" lighting style, weak lights and strong lights can still overlap. This lighting style is meant to be more natural, so it's not desirable to have a hard cutoff where weak lights meet strong lights.
In either case, the interaction between darkness and light is the same: the weaker one will be cutoff by the stronger so there is no overlap.
Possible Drawbacks
Someone may have found a use for overlapping lights in the "overtop" style, and that is being removed here.
Documentation Notes
When using the "overtop" lighting style, each lumens level is like a separate layer for lights. Different lumens levels will not overlap with each. Instead, the strongest lumens level will "win" over weaker lumens levels. If darkness and light are tied, the darkness wins.
As an example, we can augment the default torch with lumens levels to represent bright and dim:
If two tokens have torches, we can see that the bright areas are merged, and the dim areas are merged, but the dim areas do not overlap with the bright areas since the bright areas have a higher lumens value.
Release Notes
This change is