Fixed ButtonGroup drag event drop checks #4959 #4963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #4959
Description of the Change
Previous change #4888 to fix #4883 was to exit early if there was no change in a button's group.
This resulted in early exits when dragging into different panels using the same group name.
Added a check to only exit where there is no change in the group on the same panel.
Possible Drawbacks
None foreseen, but I thought that last time
Documentation Notes
Improved checks for dragging macro button
Release Notes
Fixed issue with dragging macro buttons to macro groups with the same name on other panels
This change is