Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not disclose GM maps to players in status UI #4982

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Oct 6, 2024

Identify the Bug or Feature request

Fixes #4595

Description of the Change

For player clients, this hides the name of the GM's zone in the Connections window and status bar. Players can still see each other's zones, and GMs can still see everyone's zone.

Possible Drawbacks

None

Documentation Notes

In the Connections window, players cannot see the map any GM is on. Same for the status bar indicator.

Release Notes

  • Fixed a bug where names of hidden maps are shown to players in the Connections window when a GM is on the map.

This change is Reviewable

@kwvanderlinde kwvanderlinde self-assigned this Oct 6, 2024
@cwisniew
Copy link
Member

cwisniew commented Oct 9, 2024

Although having more than one GM connected is rare, we should still probably show the information to GMs.

@kwvanderlinde
Copy link
Collaborator Author

Fair enough. I didn't think it was too important for GMs to keep track of each other, but I will add it in.

@cwisniew
Copy link
Member

Fair enough. I didn't think it was too important for GMs to keep track of each other, but I will add it in.

Its not so much keeping track of which map they were on, but the original request that generated this functionality was about knowing if maps had loaded for other users. So I can see people wanting that feature back

This hides the name of the zone in the Connections window and the status bar it won't be revealed to players.
@kwvanderlinde kwvanderlinde force-pushed the bugfix/4595-connections-window-disclosing-gm-maps branch from 2aa68ae to 7f96281 Compare October 11, 2024 01:52
@kwvanderlinde
Copy link
Collaborator Author

Updated so GMs can once again see each other's zone.

@cwisniew cwisniew added this pull request to the merge queue Oct 16, 2024
Merged via the queue into RPTools:develop with commit e96f9fc Oct 16, 2024
4 checks passed
@kwvanderlinde kwvanderlinde deleted the bugfix/4595-connections-window-disclosing-gm-maps branch November 26, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Bug]: Connections window disclosing GM maps to the players
3 participants