Simplify SelectionSet null checks case work #5098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The presence of the walker is used to indicated whether we are currently using pathfinding and snap-to-grid behaviour. We no longer check that at every opportunity. Also, the task requires a non-null walker, which was not checked. This enables us to easily check against a null walker when it matters.
bubblobill
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #5089
Description of the Change
Whenever the walker is used, we check it for
nullnow, and same for therenderPathTask, and when both are needed we consistently check the walker first and only bother withrenderPathTaskif it is set.We also avoid checking zone and token properties to decide whether we are using the walker or not, and instead only use the above null checks. The zone and token properties can change over time, and modifying them while a token is in transit used to also result in error (this is a long-standing issue with
SelectionSet). Changing these avoids these errors, though it meansSelectionSetstill doesn't react to the changes. This is something that can be handled separately and is not urgent.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
This change is