Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ISO Formatted time with UTC offset #877

Merged
merged 1 commit into from
Nov 10, 2019

Conversation

JamzTheMan
Copy link
Member

@JamzTheMan JamzTheMan commented Nov 9, 2019

Current timeDate fields in Client Info does not include any timezone information which is needed for some API calls.

New field isoTimeDate was added which now includes UTC offset following ISO 8601 standards.
such as 2019-11-09T10:15:30.3444-06:00


This change is Reviewable

Signed-off-by: JamzTheMan <JamzTheMan@gmail.com>
@Phergus
Copy link
Contributor

Phergus commented Nov 9, 2019

Don't see an issue for this.

And what is AppVeyor whining about?

@JamzTheMan
Copy link
Member Author

I thought I had created it, I will as soon as I get a chance, got pulled away from the computer.

I think CI just hiccupped downloading stuff.

Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue created #878.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Phergus
Copy link
Contributor

Phergus commented Nov 10, 2019

Completes #878

@Phergus Phergus merged commit ac4b64a into RPTools:release-1.5.7 Nov 10, 2019
@JamzTheMan JamzTheMan deleted the getinfo-utc-fix branch February 21, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants