Add AMD HSMP support to sysfeatures #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likwid-sysfeatures now also queries the categories properly, so different categories with the same feature name do not conflict.
Due to include order the missing includes did not cause problems, but in future files and commits, this must be fixed.
To give the user more flexibility when specifying numbers.
Likwid and hwloc currently have an incomplete/wrong understanding of APIC IDs and blindly assume a mapping of linux processor number to APIC ID. This is wrong. For example AMD EPYC 9354 reports gaps and jumps in its ID order. This commit makes sure to explicitly query the APIC ID via CPUID in order to correctly map LikwidDevice_t to APIC IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support currently requires the kernel module
amd_hsmpto be manually loaded and appropriate read/write permissions. Read only/Write only is not supported.