Bug fixes 06 2024 #161
Merged
Bug fixes 06 2024 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R/hts_prep_triprate.R
Outdated
| threshold = 0.975, | ||
| weighted = TRUE, | ||
| hts_data) { | ||
| hts_data = list(hts_data)) { |
There was a problem hiding this comment.
I am a little confused by this default. Shouldn't it be something like = list('hh' = hh, ...)?
There was a problem hiding this comment.
I've updated the param to the proper convention. this was also updated in hts_prep_variable.R
james-clark-rsg
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
updated syntax and resolved bugs in
hts_prep_triprate. added a warning message tohts_remove_outliersand updated the argument to default to FALSE inhts_prep_triprate.Checklist
usethis::use_version()News.mdto reflect changes madepkgdown::build_site()if adding vignettes or articles