fix: ignore partial json_encode() errors in JsonFormat (#2554)

Without this change, JsonFormat simply returns
an empty array. #2283

formats/JsonFormat.php

@@ -111,12 +111,15 @@ public function stringify(){
 		}
 		$data['items'] = $items;
 
-		$toReturn = json_encode($data, JSON_PRETTY_PRINT);
-
-		// Remove invalid non-UTF8 characters
-		ini_set('mbstring.substitute_character', 'none');
-		$toReturn = mb_convert_encoding($toReturn, $this->getCharset(), 'UTF-8');
-		return $toReturn;
+		/**
+		 * The intention here is to discard non-utf8 byte sequences.
+		 * But the JSON_PARTIAL_OUTPUT_ON_ERROR also discards lots of other errors.
+		 * So consider this a hack.
+		 * Switch to JSON_INVALID_UTF8_IGNORE when PHP 7.2 is the latest platform requirement.
+		 */
+		$json = json_encode($data, JSON_PRETTY_PRINT | JSON_PARTIAL_OUTPUT_ON_ERROR);
+
+		return $json;
 	}
 
 	public function display(){