-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GithubIssue] does not include the issue itself only the responses / comment #1100
Comments
- Add function to build an URL to the GitHub issue comment - Change scope of internal functions from protected to private - Use IDs instead of classes as comment selectors, to include the issue author in the output feed. References #1100
The issue comment from the author of an issue is now included in the feed. Let me know if this works for you. |
Still checking if i updated correctly. (Took this issue for testrun |
It looks like the $this-> is missing here rss-bridge/bridges/GithubIssueBridge.php Line 83 in da339fd
Edit: |
Thanks for the feedback. You are right, someone 👈 totally made a mistake there. Working on a fix... |
Should be fixed now. |
Thanks @logmanoriginal works for me Not related to this issue. Could u implement the detect (parameters) method for Github Issue? rss-bridge/bridges/TwitterBridge.php Line 74 in d344111
Or should i fill a new issue for that? |
Well, since I'm already working on it... |
@logmanoriginal Edit: This does Thanks for your work! |
@logmanoriginal : thank you very much for taking care of this ! Despite not contributing any more, I still follow the project closely, and I am amazed at your dedication and efficiency. |
@pmaziere Thank you very much for your good vibes. I'm happy to know that you still enjoy this project as I'm sure everyone on the team is. Let me know if you ever feel like contributing again. Your repo is still on my remotes 😉 By the way, your contributions certainly left a mark in the history of this project. Unchallenged to this day 😄 |
- Add function to build an URL to the GitHub issue comment - Change scope of internal functions from protected to private - Use IDs instead of classes as comment selectors, to include the issue author in the output feed. References RSS-Bridge#1100
For example my other issue:
https://example.org/?action=display&bridge=GithubIssue&i=1099&u=RSS-Bridge&p=rss-bridge&format=Atom
I think it's useful to include the issue itself. Or make it a option to include it or not.
The text was updated successfully, but these errors were encountered: