Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GithubIssue] does not include the issue itself only the responses / comment #1100

Closed
Pimmetje opened this issue Apr 12, 2019 · 10 comments
Closed
Labels
Bridge-Feature-Request Request for a new bridge feature

Comments

@Pimmetje
Copy link

For example my other issue:
https://example.org/?action=display&bridge=GithubIssue&i=1099&u=RSS-Bridge&p=rss-bridge&format=Atom
I think it's useful to include the issue itself. Or make it a option to include it or not.

@logmanoriginal logmanoriginal added the Bridge-Feature-Request Request for a new bridge feature label Jun 9, 2019
logmanoriginal added a commit that referenced this issue Jun 9, 2019
- Add function to build an URL to the GitHub issue comment
- Change scope of internal functions from protected to private
- Use IDs instead of classes as comment selectors, to include the
issue author in the output feed.

References #1100
@logmanoriginal
Copy link
Contributor

The issue comment from the author of an issue is now included in the feed. Let me know if this works for you.

@Pimmetje
Copy link
Author

Pimmetje commented Jun 9, 2019

Github Issue RSS-Bridge/rss-bridge #1100 was unable to receive or process the
remote website's content!

Error message: `Call to undefined function buildGitHubIssueCommentUri()`

Query string: `action=display&bridge=GithubIssue&i=1100&u=RSS-Bridge&p=rss-bridge&format=Atom`

Version: `dev.2019-06-08`

Still checking if i updated correctly. (Took this issue for testrun

@Pimmetje
Copy link
Author

Pimmetje commented Jun 9, 2019

It looks like the $this-> is missing here

$uri = buildGitHubIssueCommentUri($issueNbr, $comment->getAttribute('id'));
(also a few lines below).

Edit:
I did change the two lines. Now it works but the link to the comment does not work. It always goes to the # without the issuecomment-id

@logmanoriginal
Copy link
Contributor

Thanks for the feedback. You are right, someone 👈 totally made a mistake there. Working on a fix...

logmanoriginal added a commit that referenced this issue Jun 9, 2019
@logmanoriginal
Copy link
Contributor

Should be fixed now.

@Pimmetje
Copy link
Author

Thanks @logmanoriginal works for me

Not related to this issue. Could u implement the detect (parameters) method for Github Issue?
https://github.com/RSS-Bridge/rss-bridge/wiki/Actions#detect
Here is a example from twitter :

public function detectParameters($url){

Or should i fill a new issue for that?

@logmanoriginal
Copy link
Contributor

Well, since I'm already working on it...

logmanoriginal added a commit that referenced this issue Jun 10, 2019
@Pimmetje
Copy link
Author

Pimmetje commented Jun 10, 2019

@logmanoriginal
I tried the url from this issue. I get
RSS-Bridge was unable to transform the contents returned by Github Issue!

Edit:
My bad. The format parameter is case sensitive ...
?action=detect&format=atom&url=https%3A%2F%2Fgithub.com%2FRSS-Bridge%2Frss-bridge%2Fissues%2F1099
does not work

This does
?action=detect&format=Atom&url=https%3A%2F%2Fgithub.com%2FRSS-Bridge%2Frss-bridge%2Fissues%2F1099

Thanks for your work!

@pmaziere
Copy link
Contributor

@logmanoriginal : thank you very much for taking care of this !

Despite not contributing any more, I still follow the project closely, and I am amazed at your dedication and efficiency.
Thanks for maintaining this great tool !

@logmanoriginal
Copy link
Contributor

@pmaziere Thank you very much for your good vibes. I'm happy to know that you still enjoy this project as I'm sure everyone on the team is. Let me know if you ever feel like contributing again. Your repo is still on my remotes 😉

By the way, your contributions certainly left a mark in the history of this project.
image

Unchallenged to this day 😄

infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this issue Apr 17, 2020
- Add function to build an URL to the GitHub issue comment
- Change scope of internal functions from protected to private
- Use IDs instead of classes as comment selectors, to include the
issue author in the output feed.

References RSS-Bridge#1100
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this issue Apr 17, 2020
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this issue Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bridge-Feature-Request Request for a new bridge feature
Projects
None yet
Development

No branches or pull requests

3 participants