-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODOs #2099
Comments
Love the idea! About the release preparation scripts: You should include a github action to create a multiarch container that also builds arm versions of rss-bridge. I've prepared something in https://github.com/Bockiii/rss-bridge/tree/multiarchversion . With QEMU, it's really easy to build and manage. You can also configure an action to not trigger on every commit (as it is right now in my example) but on every release. hit me up if you want me to do that. I'm not a fan of the release cycle of rss-bridge tbh, so maybe we should talk about the releases first. There were only 2 releases in 2020. That means you will drive people away from the official releases and into self-maintained repos and instances. Maybe a "testing" branch to do PRs against and then a merge into master after testing and then just use the master branch as the latest version.. idk, but I cannot believe I am the only one who has an issue with 2 releases a year. I will take a swing at the environment variables task. I will open a "working on it"-PR so people can interact and then, when the feature is done, merge all the changes into one, good commit. |
For "Make HTML format as default feed format" Would it make sense to get rid of the whole link-row on the front page and instead go for a "Show Feed" button that leads to the html feed? This will also stop the confusion about getting the atom/mrss link for example (on the front page, you cant right-click on the button and say "copy link location", you can do that on the atom/mrss buttons on the html-view though). I think it makes the whole navigation a little more intuitive |
@em92 for the wiki topic: are you looking into readthedocs or gitbook? If you move to a new process, it might be worth looking into that. Both are free for open source projects. |
@Bockiii, I planned using markdown files on repository. They are simple and no need to host them.
By the word "release" mean those ones also I would call them "release preparation instructions and a emacs script". Docker images are different things and they are updated on every commit in master. https://hub.docker.com/r/rssbridge/rss-bridge.
That is long story for explanation. I will describe it later in discussion. |
https://medium.com/@Mister_Gold/stop-using-markdown-for-documentation-5bda05ad17e3 Markdown has it's moments to shine, but code documentation is not really one of them. rst would be the better choice (readthedocs uses rst for example. See the readthedocs example: You can also host that in the repo and not use readthedocs at all since the webviewer from github supports rst. Just dont use md :)
Ah, sorry, didn't see that yet as I've been using rssbridge basically since April 28 :). If they update on every commit, I can put in the PR to give you multiarch (armv7 and armv8 which are basically all raspberry pis except for the very first one) immediately. You then need to configure your dockerhub autobuilds but we can discuss that in the other PR then.
Okay. If the docker container uses the latest master, the releases are not that important to me :) |
Added task on [Added on May 8, 2021] |
Added task on [Added on June 26, 2021] |
Closing as seperated to different issues. |
Move all wiki pages except "Public Hosts" to repository. Reasons:
Responsible: @em92
Move release preparation scripts to
contrib/prepare_release
directory. As for now, instructions how to prepare release is hidden in one of draft releasesResponsible: @em92
(Done [core] Support for bridge maintainers' donation URLs #2102) In top of HTML format preview add link to donate bridge maintainer. Discussion about donation: About donation #2063
(Done [BridgeCard] Make HTML default, remove other buttons #2101) Make HTML format as default feed format. Reasons:
Allow to use environment variables instead of config.ini.php. Reference: How should authentication through config.ini.php be used on Heroku? #2071 (comment)
Add hidden contexts which are not shown in bridge card. Possible usages:
Add section in main instance page for using detect action
[Added on May 8, 2021]
Bridges that include "detectParameters" method must also have test samples like "link" -> "bridge parameters".
Example PR where I tried to test it: [YoutubeBridge] Add detectParameters #2108
As possible solution - make modification to BridgeImplementationTest.php that would execute testing those samples, that are defined in bridge like this
[Added on June 26, 2021]
The text was updated successfully, but these errors were encountered: