Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs #2099

Closed
3 of 9 tasks
em92 opened this issue May 3, 2021 · 9 comments
Closed
3 of 9 tasks

TODOs #2099

em92 opened this issue May 3, 2021 · 9 comments
Labels
Feature-Request Issue is a feature request

Comments

@em92
Copy link
Contributor

em92 commented May 3, 2021

[Added on May 8, 2021]

const TEST_DETECT_PARAMETERS = array(
  'https://www.youtube.com/playlist?list=PL0lo9MOBetEFEzIm3OP9_5jtkilBobdKB', array('p' => 'PL0lo9MOBetEFEzIm3OP9_5jtkilBobdKB'),
);

[Added on June 26, 2021]

@em92 em92 added the Feature-Request Issue is a feature request label May 3, 2021
@em92 em92 pinned this issue May 3, 2021
@Bockiii
Copy link
Contributor

Bockiii commented May 3, 2021

Love the idea!

About the release preparation scripts: You should include a github action to create a multiarch container that also builds arm versions of rss-bridge. I've prepared something in https://github.com/Bockiii/rss-bridge/tree/multiarchversion . With QEMU, it's really easy to build and manage. You can also configure an action to not trigger on every commit (as it is right now in my example) but on every release. hit me up if you want me to do that. I'm not a fan of the release cycle of rss-bridge tbh, so maybe we should talk about the releases first. There were only 2 releases in 2020. That means you will drive people away from the official releases and into self-maintained repos and instances. Maybe a "testing" branch to do PRs against and then a merge into master after testing and then just use the master branch as the latest version.. idk, but I cannot believe I am the only one who has an issue with 2 releases a year.

I will take a swing at the environment variables task. I will open a "working on it"-PR so people can interact and then, when the feature is done, merge all the changes into one, good commit.

@Bockiii
Copy link
Contributor

Bockiii commented May 4, 2021

@em92

For "Make HTML format as default feed format"

Would it make sense to get rid of the whole link-row on the front page and instead go for a "Show Feed" button that leads to the html feed? This will also stop the confusion about getting the atom/mrss link for example (on the front page, you cant right-click on the button and say "copy link location", you can do that on the atom/mrss buttons on the html-view though).

I think it makes the whole navigation a little more intuitive

@Bockiii
Copy link
Contributor

Bockiii commented May 4, 2021

As you can see, I switched the bridgelist behavior to only show the HTML view as default (see #2101) and I added Donation URL Support (see #2102). I'll wait for feedback before I go for another topic.

@Bockiii
Copy link
Contributor

Bockiii commented May 4, 2021

@em92 for the wiki topic: are you looking into readthedocs or gitbook? If you move to a new process, it might be worth looking into that. Both are free for open source projects.

@em92
Copy link
Contributor Author

em92 commented May 4, 2021

for the wiki topic: are you looking into readthedocs or gitbook? If you move to a new process, it might be worth looking into that. Both are free for open source projects.

@Bockiii, I planned using markdown files on repository. They are simple and no need to host them.

About the release preparation scripts: You should include a github action to create a multiarch container that also builds arm versions of rss-bridge.

By the word "release" mean those ones also I would call them "release preparation instructions and a emacs script". Docker images are different things and they are updated on every commit in master. https://hub.docker.com/r/rssbridge/rss-bridge.

I'm not a fan of the release cycle of rss-bridge tbh, so maybe we should talk about the releases first. There were only 2 releases in 2020.

That is long story for explanation. I will describe it later in discussion.

@Bockiii
Copy link
Contributor

Bockiii commented May 4, 2021

@em92

@Bockiii, I planned using markdown files on repository. They are simple and no need to host them.

https://medium.com/@Mister_Gold/stop-using-markdown-for-documentation-5bda05ad17e3

Markdown has it's moments to shine, but code documentation is not really one of them. rst would be the better choice (readthedocs uses rst for example. See the readthedocs example:
View: click
Source: click
Github webview: click

You can also host that in the repo and not use readthedocs at all since the webviewer from github supports rst. Just dont use md :)

Docker images are different things and they are updated on every commit in master.

Ah, sorry, didn't see that yet as I've been using rssbridge basically since April 28 :). If they update on every commit, I can put in the PR to give you multiarch (armv7 and armv8 which are basically all raspberry pis except for the very first one) immediately. You then need to configure your dockerhub autobuilds but we can discuss that in the other PR then.

That is long story for explanation. I will describe it later in discussion.

Okay. If the docker container uses the latest master, the releases are not that important to me :)

@em92
Copy link
Contributor Author

em92 commented May 8, 2021

Added task on [Added on May 8, 2021]

@em92
Copy link
Contributor Author

em92 commented Jun 25, 2021

Added task on [Added on June 26, 2021]

@em92 em92 unpinned this issue Aug 16, 2021
@em92 em92 added the TODO label Dec 9, 2021
@em92
Copy link
Contributor Author

em92 commented Dec 9, 2021

Closing as seperated to different issues.

@em92 em92 closed this as completed Dec 9, 2021
@em92 em92 removed the TODO label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature-Request Issue is a feature request
Projects
None yet
Development

No branches or pull requests

2 participants