Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Add custom config location #2098

Merged
merged 1 commit into from
Sep 5, 2021
Merged

Conversation

Bockiii
Copy link
Contributor

@Bockiii Bockiii commented May 1, 2021

This is the follow up to the original PR #2097 since that became pretty messy.

This is the PR for all the changes and a follow up testing (which... we didn't do during that PR :/ )

This should be clean and work (I tested this with multiple files).

@Bockiii
Copy link
Contributor Author

Bockiii commented May 1, 2021

So yes @verahawk , the find actually became an issue :D Fixed with this version.

@Bockiii
Copy link
Contributor Author

Bockiii commented May 1, 2021

This change would also need some overhaul of the wiki sections, I will do that after the merge.

@Bockiii
Copy link
Contributor Author

Bockiii commented Jul 30, 2021

@em92 this feature is super useful for development btw. I'm using this branches container for everything since I only have to spin up one container and just add bridges to a mapped folder.

@Bockiii
Copy link
Contributor Author

Bockiii commented Aug 30, 2021

@em92 Can you tell my why you're not adding this? It's really super usefull :)

@em92 em92 merged commit 455b5e0 into RSS-Bridge:master Sep 5, 2021
@em92
Copy link
Contributor

em92 commented Sep 5, 2021

Can you tell my why you're not adding this?

Problems with free time recently.

@Bockiii
Copy link
Contributor Author

Bockiii commented Sep 9, 2021

@em92 I updated the docker wiki page

https://github.com/RSS-Bridge/rss-bridge/wiki/Docker

@th0mcat
Copy link

th0mcat commented Sep 20, 2021

EDIT: Oh, now I see the latest container hasn't been updated in 2 months, and this was only merged 21 days ago. Is there an update coming for that docker tag?


For the life of me, I cannot get the docker container to read whitelist.txt or config.ini.php from my bind mount volume. I have them both in /opt/rss-bridge, chowned to www-data and chmoded to 775.

  rss-bridge:
    image: rssbridge/rss-bridge:latest
    container_name: rss-bridge
    hostname: rss-bridge
    volumes:
      - /opt/rss-bridge:/config:rw
...
user@server:/opt$ ls -la /opt/rss-bridge/
total 16
drwxrwxr-x  2 www-data www-data 4096 Sep 20 11:40 .
drwxrwxr-x 61 user  user  4096 Sep 20 11:48 ..
-rwxrwxr-x  1 www-data www-data 2428 Sep 20 10:49 config.ini.php
-rwxrwxr-x  1 www-data www-data   19 Sep 20 11:40 whitelist.txt
root@container:/config# ls -la
total 16
drwxrwxr-x 2 www-data www-data 4096 Sep 20 16:40 .
drwxr-xr-x 1 root     root     4096 Sep 20 16:44 ..
-rwxrwxr-x 1 www-data www-data 2428 Sep 20 15:49 config.ini.php
-rwxrwxr-x 1 www-data www-data   19 Sep 20 16:40 whitelist.txt

@Bockiii
Copy link
Contributor Author

Bockiii commented Sep 20, 2021

@thomcatdotrocks Congrats, you found a major issue :D

Dockerhub changed their autobuild policy and ... someone forgot....

I created #2268 to fix this.

@th0mcat
Copy link

th0mcat commented Sep 20, 2021

😶 Huh. That's pretty crappy of Docker, but I guess we should have expected that at some point.

Glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants