Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement action factory #1002

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Implement action factory #1002

merged 1 commit into from
Feb 6, 2019

Conversation

logmanoriginal
Copy link
Contributor

@logmanoriginal logmanoriginal commented Jan 8, 2019

This PR is about reducing the size of index.php by moving actions into separate classes and making them available via an ActionFactory. That way additional actions can be added and tested without touching existing ones. The behavior is similar to bridges, formats and caches.

Tasks

  • Link actions in a factory class instead of using a case structure
  • Implement a base class for factory classes (partially done)
  • Add separate classes for each action
    • Display
    • List
    • Detect
  • Add tests
  • Add documentation
  • Code cleanup
  • Testing

References #1001

Let me know if you have further suggestions for improvements.

@logmanoriginal logmanoriginal added Code-Refactoring Code refactoring Code-Investigation-Needed Code needs to be investigated labels Jan 8, 2019
@logmanoriginal logmanoriginal self-assigned this Jan 8, 2019
@logmanoriginal logmanoriginal changed the title [WIP] Implement action factory Implement action factory Feb 6, 2019
@logmanoriginal logmanoriginal merged commit 51ee541 into RSS-Bridge:master Feb 6, 2019
@logmanoriginal logmanoriginal deleted the ActionFactory branch June 23, 2019 07:37
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-Investigation-Needed Code needs to be investigated Code-Refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant