Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQLiteCache] Implemented cache based on SQLite 3 #1035

Merged
merged 3 commits into from
Feb 24, 2019

Conversation

fulmeek
Copy link
Contributor

@fulmeek fulmeek commented Feb 14, 2019

Since SQLite is a small embedded serverless database engine which is widely used and easy to maintain, it is suitable for use as cache. The developers even claim that SQLite is faster than reading and writing indivual files. For me, it helps to not have thousands of cache files.

In order to use it, set the cache type to "sqlite" in your config.ini.php

This should allow to write caches with additional depencies on construction, which are not subject of this test.
@fulmeek
Copy link
Contributor Author

fulmeek commented Feb 19, 2019

As you might have noticed, I modified the CacheImplementationTest. Since cache implementations most likely have additional dependencies, we should avoid creating an instance of them in a general test. So, this now simply checks if the class itself is a subclass of CacheInterface instead.
I think it makes writing caches easier (em92 appears to have trouble with it in #1000).

If you need it in a separate PR, let me know.

@logmanoriginal logmanoriginal merged commit dc1b1b1 into RSS-Bridge:master Feb 24, 2019
@logmanoriginal
Copy link
Contributor

Great addition, I like it a lot! 👍

@fulmeek fulmeek deleted the upstream-SQLiteCache branch February 24, 2019 17:39
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants