[BandcampBridge] Update to use newer POST API #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeek502
changed the title
squeek502
force-pushed
the
bandcamp-update
branch
from
b35926f to
4764db6
Compare
Bandcamp tags pages have a new layout and now use a POST API endpoint to view each page of releases. Output of this bridge should be almost the same as before, with a few small improvements: - Small album image in 'content', larger album image in 'enclosures' - RSS item titles/authors are appended with the releaser in parentheses if the artist name and the releaser are different (i.e. Record Label's Bandcamp releases an album called Bar by the band named Foo, it would get the title 'Foo - Bar (Record Label)' and the author 'Foo (Record Label)')
squeek502
force-pushed
the
bandcamp-update
branch
from
4764db6 to
7571a4a
Compare
|
Merged. Thanks for the PR! |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
Bandcamp tags pages have a new layout and now use a POST API endpoint to view each page of releases. Output of this bridge should be almost the same as before, with a few small improvements: - Small album image in 'content', larger album image in 'enclosures' - RSS item titles/authors are appended with the releaser in parentheses if the artist name and the releaser are different (i.e. Record Label's Bandcamp releases an album called Bar by the band named Foo, it would get the title 'Foo - Bar (Record Label)' and the author 'Foo (Record Label)')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bandcamp tags pages have a new layout and now use a POST API endpoint to view each page of releases. This PR updates the Bandcamp bridge to use that new API.
Output of this bridge should be almost the same as before, with a few small improvements:
Note: As of right now, Bandcamp seems to be A/B testing the new layout (repeating the same request to https://bandcamp.com/tag/rock?sort_field=date will sometimes get you the new layout and sometimes the old one). This means that the current bridge will unpredictably fail and produce a feed with 0 items. This PR will work 100% of the time, even while this A/B testing is going on.