Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BakaUpdatesMangaReleasesBridge] reworked to parse new layout #1052

Conversation

fulmeek
Copy link
Contributor

@fulmeek fulmeek commented Feb 28, 2019

The dinosaurs tried to made their ancient table layout mobile, so they used a huge pile of divs to recreate their dusty design. May it last for another 15 years or so.

This PR reflects the new layout of Baka-Updates Manga.

The last row could have fewer columns if there are less rows than the items limit. This usually should not happen, though.
@logmanoriginal logmanoriginal merged commit 9d85b95 into RSS-Bridge:master Mar 2, 2019
@logmanoriginal
Copy link
Contributor

Merged. Thanks for the PR!

The dinosaurs tried to made their ancient table layout mobile, so they used a huge pile of divs to recreate their dusty design. May it last for another 15 years or so.

They'll probably discover the "new" HTML 5 elements in a few years 😆

@fulmeek fulmeek deleted the upstream-BakaUpdatesMangaReleasesBridge branch March 6, 2019 18:22
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
…ge#1052)

* rework to parse new layout
* skip incomplete rows

The last row could have fewer columns if there are less rows than the items limit. This usually should not happen, though.

* use constant for skipping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants