[ParameterValidator] Handle missing parameter type

[Roliga]

If the 'type' property for a required parameter is not specified it was treated as if it was not required by getQueriedContext since 434c126.

Maybe there's some more readable way to write this but this seems to make it work as intended at least!

[logmanoriginal]

You are right, the current condition is wrong if the type is not specified. It actually took me a while to understand how the condition works (which is funny because I wrote it myself... not a good sign).

Your condition is correct though.

Maybe there's some more readable way to write this but this seems to make it work as intended at least!

Indeed. One way this can be simplified is by putting in a guard clause like this (haven't tested it):

// Check if all parameters of the context are satisfied
foreach($set as $id => $properties) {
    if(isset($data[$id]) && !empty($data[$id])) {
        $queriedContexts[$context] = true;
    } elseif (isset($properties['type'] 
    && ($properties['type'] === 'checkbox' || $properties['type'] === 'list'))) {
        continue;
    } elseif(isset($properties['required']) && $properties['required'] === true) {
        $queriedContexts[$context] = false;
        break;
    }
}

The second elseif checks if the type is set and any of the not supported types, in which case the remaining loop is skipped. That should make it easier to understand imo. What do you think?

[Roliga]

Forgot a bit about this for a while, but yes that looks much better to me! I added a commit with the suggested changes.

[teromene]

Looks good to me ! Thanks for the PR !