Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EconomistBridge] Add new bridge #1067

Merged
merged 5 commits into from
Apr 4, 2019

Conversation

thefranke
Copy link
Contributor

Adds a new bridge for the latest stories on The Economist.

Filters out the "Subscribe to Newsletter" form and some links at the bottom of each article.

Copy link
Contributor

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Find below a few points for consideration.

In this case it also makes sense to add the getIcon function, so feed aggregators can get the favicon:

public function getIcon() {
	return 'https://www.economist.com/sites/default/files/econfinal_favicon.ico';
}

bridges/EconomistBridge.php Outdated Show resolved Hide resolved
bridges/EconomistBridge.php Outdated Show resolved Hide resolved
bridges/EconomistBridge.php Show resolved Hide resolved
@thefranke
Copy link
Contributor Author

Thanks for the review, I've added all changes.

@logmanoriginal
Copy link
Contributor

Thanks for the updates. One small change regarding the item limit:

if (count($this->items) >= 10)
	break;

$this->items[] = $item;

This checks the limit before adding items, but it should be checked afterwards:

$this->items[] = $item;

if (count($this->items) >= 10)
	break;

@thefranke
Copy link
Contributor Author

The limit issue is fixed

@teromene teromene merged commit 50c90eb into RSS-Bridge:master Apr 4, 2019
@teromene
Copy link
Member

teromene commented Apr 4, 2019

Perfect ! Thanks !

infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
* [EconomistBridge] Added new bridge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants