Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboiosDePortugalBridge: HACK: Encode the URL #1074

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

somini
Copy link
Contributor

@somini somini commented Mar 24, 2019

This seems like a weird bug somewhere.

Either the HTML parser should return the valid page, or the CMS should
not convert the URL first, or the URL validation regex is buggy.

This seems like a weird bug somewhere.

Either the HTML parser should return the valid page, or the CMS should
not convert the URL first, or the URL validation regex is buggy.
@somini
Copy link
Contributor Author

somini commented Mar 24, 2019

This is the offending link, it is no longer on the page now:

https://www.cp.pt/passageiros/pt/consultar-horarios/avisos/bilheteiras-4-5-mar%C3%A7o

Worse, that link is no longer valid, it seems they purge the old warnings very fast. :|

What matters is that that href was returned as /passageiros/pt/consultar-horarios/avisos/bilheteiras-4-5-março.

@teromene teromene merged commit c9b0cd1 into RSS-Bridge:master Apr 4, 2019
@teromene
Copy link
Member

teromene commented Apr 4, 2019

Weird...
Merged, thanks !

@somini somini deleted the fix-bridge/cppt branch February 27, 2020 01:30
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
This seems like a weird bug somewhere.

Either the HTML parser should return the valid page, or the CMS should
not convert the URL first, or the URL validation regex is buggy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants