Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QPlayBridge]: New Bridge #1118

Merged
merged 7 commits into from
May 29, 2019
Merged

Conversation

somini
Copy link
Contributor

@somini somini commented Apr 30, 2019

Yet another super specific bridge, but this site uses the uscreen platform, it might be used as a template for other sites.

The other public sites I tested hide all this from anonymous users, so I scrapped the generic version of this.

bridges/QPlayBridge.php Outdated Show resolved Hide resolved
@somini somini marked this pull request as ready for review April 30, 2019 16:59
Copy link
Member

@teromene teromene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just small comments before we can merge !

bridges/QPlayBridge.php Outdated Show resolved Hide resolved
bridges/QPlayBridge.php Outdated Show resolved Hide resolved
bridges/QPlayBridge.php Outdated Show resolved Hide resolved
bridges/QPlayBridge.php Outdated Show resolved Hide resolved
bridges/QPlayBridge.php Outdated Show resolved Hide resolved
@somini
Copy link
Contributor Author

somini commented May 3, 2019

Thanks for the review, commited those changes.

@somini
Copy link
Contributor Author

somini commented May 4, 2019

Copy link
Contributor

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, nice bridge. Find below two suggestions

It's still erroring out here:

https://github.com/somini/rss-bridge/blob/2cd86e79a690a542a6b6b49098de7e145ec3d25e/bridges/QPlayBridge.php#L24-L29

The getIcon function is optional and should return a direct link to the favicon. Please try to avoid loading contents in this function. The following code should work fine.

public function getIcon() {
	return 'https://s3.amazonaws.com/unode1/assets/4957/r3T9Lm9LTLmpAEX6FlSA_apple-touch-icon.png';
}

If the location of the icon changes, leaving the function out is probably the best option.

bridges/QPlayBridge.php Outdated Show resolved Hide resolved
bridges/QPlayBridge.php Outdated Show resolved Hide resolved
somini added 2 commits May 15, 2019 22:55
Remove fetching data on `getIcon`
@somini
Copy link
Contributor Author

somini commented May 15, 2019

Many thanks for the review, commited your (thoughtful) recommendations.

@teromene teromene merged commit 84d48d5 into RSS-Bridge:master May 29, 2019
@teromene
Copy link
Member

Thanks for taking in account @logmanoriginal's requests ! Merged !

@somini somini deleted the new-bridge/qplay branch February 27, 2020 01:30
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants