Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SteamBridge] Follow source changes #1143

Merged
merged 3 commits into from
Jun 6, 2019

Conversation

JackNUMBER
Copy link
Contributor

Steam changed there data fetching (now using a XHR), currencies are not customizable (now depending of IP requester) and some pictures has quiet different filename (substr() was a bad solution). The bridge didn't work anymore, then these commits make it work again and improve some parts.

The request needs an id and not a username anymore, easy to find with steamid.io or steamidfinder.com.

Steamid64 for test: 76561198821231205

@JackNUMBER JackNUMBER changed the title Fix Steam Bridge [SteamBridge] Follow source changes May 30, 2019
Copy link
Contributor

@logmanoriginal logmanoriginal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the bridge 👍

Find below a few points for consideration.

bridges/SteamBridge.php Show resolved Hide resolved
bridges/SteamBridge.php Show resolved Hide resolved
bridges/SteamBridge.php Outdated Show resolved Hide resolved
bridges/SteamBridge.php Outdated Show resolved Hide resolved
@JackNUMBER JackNUMBER force-pushed the master branch 3 times, most recently from 81986ce to 7d7b096 Compare June 3, 2019 22:34
@JackNUMBER
Copy link
Contributor Author

@logmanoriginal Fixed. Thank you for the review.

@logmanoriginal logmanoriginal merged commit 1814116 into RSS-Bridge:master Jun 6, 2019
@logmanoriginal
Copy link
Contributor

Merged. Thanks for keeping it updated 👍

infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
* Follow source data fetching changes
* Improve media path building
* Improve price fetching and display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants