Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeedItem] avoid repeated UID hashing #1148

Merged
merged 2 commits into from
Jun 1, 2019

Conversation

fulmeek
Copy link
Contributor

@fulmeek fulmeek commented Jun 1, 2019

This fixes the following issue:

  1. bridge sets unique ids for the items (ids get hashed)
  2. items go to the cache
  3. on next run items get loaded from cache
  4. these items have different ids because they were hashed again
  5. they show up twice in feed reader

fulmeek and others added 2 commits June 1, 2019 17:25
This fixes the following issue:
1. bridge sets unique ids for the items (ids get hashed)
2. items go to the cache
3. on next run items get loaded from cache
4. these items have different ids because they were hashed again
5. they show up twice in feed reader
@logmanoriginal
Copy link
Contributor

Thanks for the PR, makes totally sense to me 👍
I fixed the 'elseif' typo directly because it's such a small thing (and Travis favors both for some reason). 🤷‍♂️

@logmanoriginal logmanoriginal merged commit 66c5b73 into RSS-Bridge:master Jun 1, 2019
@fulmeek fulmeek deleted the upstream-FeedItem branch June 1, 2019 20:16
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
…ridge#1148)

This fixes the following issue:

1. bridge sets unique ids for the items (ids get hashed)
2. items go to the cache
3. on next run items get loaded from cache
4. these items have different ids because they were hashed again
5. they show up twice in feed reader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants