[StoriesIGBridge] New bridge #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally checks passed... sorry for the commit mess 😅 |
| $item['uri'] = $result->find('div.download', 0)->find('a', 0)->href; | ||
| $item['author'] = $this->getInput('username'); | ||
| $item['uid'] = $result->find('time', 0)->datetime; | ||
|
|
There was a problem hiding this comment.
You should set a timestamp for each item or the current time and date is used.
$item['timestamp'] = strtotime($result->find('time', 0)->datetime);| $this->items[] = $item; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Consider using getName to set a custom title for each feed instead of always using the bridge name.
public function getName() {
if (!is_null($this->getInput('username'))) {
return $this->getInput('username') . ' - ' . self::NAME;
}
return parent::getName();
}
|
Thanks for the PR! |
|
This bridge uses a third-party service (https://storiesig.com) so it's probably best to keep the two separate. |
|
I see, thanks for the clarification. You are right, it should be kept separated. |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
* Create StoriesIGBridge.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a new bridge to display Instagram stories based on https://storiesig.com service.
You can try with this user for instance : raspberrypifoundation
This can solve #694 #1056 #665