-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TwitterBridge] Enable cookies with curl #1245
Conversation
Enable cookies in curl, or fall back to `file_get_contents` if in CLI mode with no curl root certificates.
This really seems like a workaround that we can't use everywhere... |
I'm not sure I understand your point. This PR is purely about enabling cookies with cURL for for TwitterBridge so that |
I guess my question was more: Why do we still have file_get_contents in cli while we no longer use it in web mode ? |
For my particular use-case which might be shared by others. Unlike I'm not sure how Linux handles things, but on Windows this means downloading cacert.pem from https://curl.haxx.se/docs/caextract.html and keeping it up to date. Personally I'd much rather use the root certificates which Windows automatically keeps up to date, which is what I added this in PR #962 which @logmanoriginal merged. |
All right. Though I believe that we should, later, remove entirely the dependency to file_get_contents in |
I would like
I don't even have the cUrl module enabled at the moment and everything works fine, including certificate verification. As for FB2Bridge, how about reusing the code from this PR, so that |
On further testing, it seems it's only Windows which the cUrl module is unable to use the system's root certificates. Another proposal is to leave Linux alone and do:
|
* [TwitterBridge] Enable cookies with curl Enable cookies in curl, or fall back to `file_get_contents` if in CLI mode with no curl root certificates.
Enable cookies in curl, or fall back to
file_get_contents
if in CLI mode with no curl root certificates.Fixes issues on some installations where
allow_url_fopen
is disabled. #1231Credit @Roliga for curl method.