Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FacebookBridge.php detectParameters method #1320

Closed
wants to merge 5 commits into from
Closed

Update FacebookBridge.php detectParameters method #1320

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 7, 2019

No description provided.

@ghost ghost closed this Oct 8, 2019
@ghost ghost reopened this Oct 8, 2019
@somini
Copy link
Contributor

somini commented Oct 12, 2019

This is actually 2 PR in 1.

What does that translation action do really?

@ghost
Copy link
Author

ghost commented Oct 14, 2019

Yes, sorry. I am not yet familiar with GitHub. Is it possible to divide into two pull requests via web interface? The translate action converts a URL to the equivalent feed url. Like requested here:
#1099

mw80 added 2 commits October 14, 2019 11:18
@ghost
Copy link
Author

ghost commented Oct 14, 2019

I was able to revert the commits regarding translation.

This was referenced Oct 14, 2019
@somini
Copy link
Contributor

somini commented Oct 14, 2019

In this particular case, there was need to revert commits, just create a new branch for the first one. For the translator commits, the easiest way is to just create a new branch based on master and cherry-pick both commits over that.

I did just that and opened #1334 and #1335. You can close this PR is you want, the code is included on those PR. All credit to you, many thanks for your contribution, I just arranged the code on git.

@ghost
Copy link
Author

ghost commented Oct 15, 2019

Thanks for your support!

@ghost ghost closed this Oct 15, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant