-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RevolutBridge] Add new bridge #1321
Conversation
LGTM. Travis complains about line 75, but I actually prefer the code as-is. |
I believe that line 75 would actually be better if it was line-splited after variables, and not separating two strings. |
I really disliked the way it looks, being split after the variables. Now I am using the PHP Simple HTML DOM Parser to insert the variables into the string. What do you think about it? |
Looks great to me ! LGTM ! |
What's the purpose of this bridge since there's already a feed available for this site ? |
It even has the full post contents. This PR has a couple months, I'm not sure this was advertised on the page on this was opened and merged. I agree that removing this bridge would be acceptable. |
Please correct me if I'm wrong, it doesn't look like the feed is linked on the page which makes it rather difficult to find. It probably makes sense to refactor the current bridge into a bridge that inherits from |
Permit me to quote the README of rss-bridge :
The purpose of a bridge is to generate RSS feed when there's no other solution. |
Even though, there's still an existing feed available. Why RSS Bridge whould help fix a layout issue ? |
The rss icon on their page is white on white background and links to a non functional page But indeed they have the correct link in the websites head section so in my opinion we can delete the bridge |
Because it's awesome, even for little things like that 😁
Thanks for looking into it. Incidentally, their search bar is also broken (the search button appears in front of "Community" on my browser): If you are a regular user, maybe send them a short message to point them in the right direction. Thanks for your contribution 👍 |
An official RSS feed is available at https://blog.revolut.com/rss/ Note that there is also an invisible "RSS" button next to the Facebook and Twitter icons at the menu bar. References #1321
* [RevolutBridge] Add new bridge
An official RSS feed is available at https://blog.revolut.com/rss/ Note that there is also an invisible "RSS" button next to the Facebook and Twitter icons at the menu bar. References RSS-Bridge#1321
Add bridge for the Revolut blog https://blog.revolut.com/