[FacebookBridge] Fix permalink issue #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Facebook has changed their strategy regarding permalinks, which now include lots of unnecessary target data. Fortunately it also contains the unique story id which we can utilize as URI.
|
Your code works for me but none of my feeds were affected by the permalink issue. I wonder if the two different link formats depends on whether the Facebook page was initially set up as a "Business" or a "Community" page. |
|
Thanks for your feedback, really appreciate it.
Perhaps, yes. Unfortunately there is no way to know for sure, but as long as it works 🤷♂️ |
infominer33
pushed a commit
to web-work-tools/rss-bridge
that referenced
this pull request
Apr 17, 2020
Facebook has changed their strategy regarding permalinks, which now include lots of unnecessary target data. Fortunately it also contains the unique story id which we can utilize as URI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facebook has changed their strategy regarding permalinks, which
now include lots of unnecessary target data. Fortunately it also
contains the unique story id which we can utilize as URI.
Closes #969
It seems to work on my end (link points to the story), but I'd like some feedback from actual users before merging.