Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FeedMergeBridge] Add new bridge #1385

Merged
merged 9 commits into from
Apr 8, 2022
Merged

[FeedMergeBridge] Add new bridge #1385

merged 9 commits into from
Apr 8, 2022

Conversation

AntoineTurmel
Copy link
Contributor

Here is a bridge that basically merge two feeds in one.
I'm not sure it's the best way, but it works for me.

Antoine Turmel added 3 commits December 6, 2019 00:37
[FeedMergeBridge] Add new bridge
c54961c 
Here is a bridge that basically merge two feeds in one.
I'm not sure it's the best way, but it works for me.
Update FeedMergeBridge.php
1968f21
Update FeedMergeBridge.php
0501617
@logmanoriginal
Copy link
Contributor

What is the use case for the bridge?
Wouldn't a feed aggregator be better suited for this?

@AntoineTurmel
Copy link
Contributor Author

Some usecases:

  • Maximum feed limit for free plan on some aggregator services
  • Custom single feed URL built with various content from other feeds (for integration)
  • Integrate multiple bridges together: SteamBridge + SteamCommunityBridge / InstagramBridge + StoriesIGBridge...

@Nick-Shannon
Copy link

I second this.

Some widgets accept only one rss feed.
I'm looking for a way to combine rss feeds into one.

@AntoineTurmel
Copy link
Contributor Author

would it also be possible to make the amount of feeds to merge dynamic?

I don't think it's possible with the current parameters system to add dynamically more text fields...

@em92
Copy link
Contributor

em92 commented Jan 27, 2020

I suggest to fork rss-bridge and implement feed merging as a separate project.

Reasons:

  1. Rss-bridge's goal and feed merging goal are different
  2. You can make changes in code to add dynamic text inputs without considering current parameters system

@AntoineTurmel
Copy link
Contributor Author

As is it just a bridge, I'll keep it under a personal repository.
Forking could be a good idea, I'll look before if there are other alternatives in PHP first.

@deathbybandaid
Copy link

deathbybandaid commented Feb 23, 2020 •
edited
Loading

Some Use Cases:

  1. There are some feeds that I use the "Filter" bridge without filtering. This allows me to utilize the caching done via rss-bridge to multiple devices. EDIT I copied the Filter bridge and trimmed the filtering aspect out and made a cache bridge. (I'm not a php expert, so I'm sure there is a cleaner way)

  2. Linus Media Groups on Youtube has multiple channels. It would be cool to be able to aggregate multiple channel feeds into 1 before it goes to my selfhosted Selfoss.

As for the goals of this bridge versus the projects being different,,, I'd personally see it as equivalent to the existing "filter" bridge.

@teromene
Copy link
Member

I am OK with this, as we already have multiple bridges that are not just transforming content, but I am listening if anyone is disagreeing,
Your thoughts, @logmanoriginal ?

@jlelse
Copy link

jlelse commented Jun 9, 2020

This looks like a really nice addition, I was looking for something like this 👍

@dvikan
Copy link
Contributor

dvikan commented Nov 29, 2021

In my opinion we should try to keep this project pure with mostly bridges. We are not a feed reader.

@dvikan
Copy link
Contributor

dvikan commented Mar 22, 2022

Let's revisit this topic. I understand the scenarios where this is useful. And it doesn't hurt much to add one bridge that is a little bit special.

@logmanoriginal
Copy link
Contributor

Limiting the use of feeds by disallowing multiple feeds in a feed aggregator clearly defeats the purpose of an aggregator...

In my opinion this falls under the category of crippled APIs that rss-bridge is aimed at.

@dvikan
Copy link
Contributor

dvikan commented Mar 29, 2022

@AntoineTurmel I'm fine with merging this. Can you add proper example values and fix all linting issues etc?
http://lorem-rss.herokuapp.com/

Bockiii
Bockiii approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@Bockiii Bockiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added examplevalues

bridges/FeedMergeBridge.php Outdated Show resolved Hide resolved
bridges/FeedMergeBridge.php Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 29, 2022 •
edited
Loading

Pull request artifacts

file last change
FeedMerge-pr-context1 2022-04-08, 19:12:03

@Bockiii
Copy link
Contributor

Bockiii commented Mar 29, 2022

There are some errors in the preview about the feedname. It looks like you want to merge the feednames but it's not doing it. Can you take a look at that? Thanks

@dvikan
Copy link
Contributor

dvikan commented Apr 8, 2022

@AntoineTurmel Ping

@dvikan
Test to see whether I can commit to PR branch
3bf10a0
@dvikan
fix up bridge
f4eadcc
@dvikan
Run phpcs . --standard=phpcs.xml --warning-severity=0 --extensions=ph…
e2bcab1 
…p -p

............................................................  60 / 372 (16%)
............................................................ 120 / 372 (32%)
............................................................ 180 / 372 (48%)
............................................................ 240 / 372 (65%)
............................................................ 300 / 372 (81%)
..............................................E............. 360 / 372 (97%)
............                                                 372 / 372 (100%)

FILE: ...me/runner/work/rss-bridge/rss-bridge/bridges/FeedMergeBridge.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 8 | ERROR | String concat is not required here; use a single string
   |       | instead
@dvikan
style: lint
f922789
@dvikan dvikan merged commit 51d2730 into RSS-Bridge:master Apr 8, 2022
@dvikan
Copy link
Contributor

dvikan commented Apr 8, 2022

I fixed it up and merged it.

@AntoineTurmel AntoineTurmel deleted the patch-6 branch April 10, 2022 15:37
@AntoineTurmel
Copy link
Contributor Author

@dvikan I was busy with other things, thanks for fixing it :)

Kwbmm pushed a commit to Kwbmm/rss-bridge that referenced this pull request Jun 17, 2022
@Bockiii @dvikan @Kwbmm
[FeedMergeBridge] Add new bridge (RSS-Bridge#1385)
b97e17f 
* [FeedMergeBridge] Add new bridge

Here is a bridge that merges two or more feeds into one.

Co-authored-by: Bocki <henning@bocklage.com>
Co-authored-by: Dag <me@dvikan.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bockiii Bockiii Bockiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@AntoineTurmel @logmanoriginal @Nick-Shannon @em92 @deathbybandaid @teromene @jlelse @dvikan @Bockiii