Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GoComics] Update to new website structure #1464

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

stjohnjohnson
Copy link
Contributor

GoComics.com has updated their website. The image location is now a
data attribute in a div.

Here is an example from https://www.gocomics.com/lio/2020/02/21:

<div class="comic container js-comic-2952528 js-item-init js-item-share js-comic-swipe bg-white border rounded" data-shareable-model="FeatureItem"
--
  | data-shareable-id="2952528"
  | data-transcript=""
  | data-id="2952528"
  | data-feature-id="162"
  | data-feature-name="Lio"
  | data-feature-code="lio"
  | data-feature-type="comic"
  | data-feature-format="print"
  | data-date="2020-02-21"
  | data-formatted-date="February 21, 2020"
  | data-url="https://www.gocomics.com/lio/2020/02/21"
  | data-creator="Mark Tatulli"
  | data-title="Lio for February 21, 2020 \| GoComics.com"
  | data-tags=""
  | data-description="For February 21, 2020"
  | data-image="https://assets.amuniversal.com/298bf7002b690138e5f1005056a9545d"
  | itemtype="http://schema.org/CreativeWork"
  | accountableperson="Andrews McMeel Universal"
  | creator="Mark Tatulli">

GoComics.com has updated their website.  The image location is now a
data attribute in a div.
@deathbybandaid
Copy link

I just patched my bridge file, and this looks to be working perfectly! Thank You!

@somini
Copy link
Contributor

somini commented Feb 25, 2020

Can confirm this fixes it, the master branch is broken otherwise. Pinging @RSS-Bridge.

The fail on Travis is unrelated, the fix is on #1458 .

@teromene teromene merged commit e102353 into RSS-Bridge:master Feb 26, 2020
@teromene
Copy link
Member

Thank you for the fix !

infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
GoComics.com has updated their website.  The image location is now a
data attribute in a div.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants