Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker] Install memcached PHP extension from PECL #1473

Merged
merged 1 commit into from
Aug 7, 2020
Merged

[docker] Install memcached PHP extension from PECL #1473

merged 1 commit into from
Aug 7, 2020

Conversation

captn3m0
Copy link
Contributor

@captn3m0 captn3m0 mentioned this pull request Feb 27, 2020
Merged
SuperSandro2000
SuperSandro2000 reviewed Mar 1, 2020
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Mar 1, 2020
View reviewed changes
SuperSandro2000
SuperSandro2000 suggested changes Mar 1, 2020
View reviewed changes
Copy link
Contributor

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two comments which I think should be addressed.

@captn3m0
[docker] Install memcached PHP extension from PECL
f48c0df 
- Adapted from https://stackoverflow.com/a/41575677
- Tested by running `php -m`
- SimpleXML now comes pre-installed with PHP, so removed the extra step
- Adds --no-install-recommends

Signed-off-by: Nemo <me@captnemo.in>
@captn3m0 captn3m0 force-pushed the cleaner-memcached-install branch from e8d0718 to f48c0df Compare March 6, 2020 08:47
@captn3m0
Copy link
Contributor Author

captn3m0 commented Mar 6, 2020

This should be good to merge 👍 :shipit:

@captn3m0
Copy link
Contributor Author

captn3m0 commented Aug 6, 2020

bump.

@em92 em92 merged commit be08970 into RSS-Bridge:master Aug 7, 2020
@em92
Copy link
Contributor

em92 commented Aug 7, 2020

Thanks @captn3m0 !

@captn3m0 captn3m0 deleted the cleaner-memcached-install branch August 9, 2020 13:21
comlaterra pushed a commit to comlaterra/rss-bridge that referenced this pull request Sep 25, 2020
@captn3m0 @comlaterra
[docker] Install memcached PHP extension from PECL (RSS-Bridge#1473)
9397a6c 
- Adapted from https://stackoverflow.com/a/41575677
- Tested by running `php -m`
- SimpleXML now comes pre-installed with PHP, so removed the extra step
- Adds --no-install-recommends

Signed-off-by: Nemo <me@captnemo.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabberworm sabberworm sabberworm left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@captn3m0 @em92 @sabberworm @SuperSandro2000