Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TheFarSideBridge] Add Bridge #1484

Merged
merged 6 commits into from
Apr 3, 2021
Merged

[TheFarSideBridge] Add Bridge #1484

merged 6 commits into from
Apr 3, 2021

Conversation

VerifiedJoseph
Copy link
Contributor

Adds bridge for The Far Side's Daily Dose.

To get around the hotlink protection, images are downloaded, encoded as base64 and then added to the HTML.

Closes #1403

@somini
Copy link
Contributor

somini commented Mar 18, 2020

LGTM.

Hard to understand that GoComics built an entire new site, instead of being a regular comic on their platform, we already have a GoComics bridge.

@Poorchop
Copy link

Is there anything in particular keeping this from getting merged? Thinking that The Far Side was already supported was one of the main reasons that I installed RSS Bridge.

@somini
Copy link
Contributor

somini commented Mar 23, 2021

I don't know exactly who has commit access, I'm just a user and run an instance myself.

@VerifiedJoseph
Copy link
Contributor Author

@em92 can you merge this, please.

Copy link
Contributor

@em92 em92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @VerifiedJoseph ! See suggestions below

bridges/TheFarSideBridge.php Outdated Show resolved Hide resolved
bridges/TheFarSideBridge.php Outdated Show resolved Hide resolved
@em92
Copy link
Contributor

em92 commented Apr 2, 2021

Is there anything in particular keeping this from getting merged? Thinking that The Far Side was already supported was one of the main reasons that I installed RSS Bridge.

@Poorchop for some reason, this PR was not in my notifications until VerifiedJoseph metioned me.

@VerifiedJoseph VerifiedJoseph requested a review from em92 April 3, 2021 14:01
@em92 em92 merged commit 5966cc0 into RSS-Bridge:master Apr 3, 2021
@Poorchop
Copy link

Poorchop commented Apr 3, 2021

Thanks for this, it's awesome. Thanks in general to everyone who helped develop and maintain this project.

@VerifiedJoseph VerifiedJoseph deleted the TheFarSideBridge branch October 4, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge request for The Far Side
4 participants